[SPARK-53786][SQL] Default value with special column name should not conflict with real column #52530
+227
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szehon-ho
force-pushed
the
default_value_conflict_2
branch
from
4169743 to
e5a4fe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the analysis of default value expression to not include column names
Why are the changes needed?
The following query:
CREATE TABLE t (current_timestamp DEFAULT current_timestamp)fails with an exception:
This is because , to create a default value DSV2 expression, the code now uses the main analyzer to analyze the default value, which resolves it to the column current_timestamp. However, analyzer should not try to resolve default value to other columns.
Does this PR introduce any user-facing change?
Should fix a regression
How was this patch tested?
Add new unit test in DataSourceV2SQLSuite
Was this patch authored or co-authored using generative AI tooling?
No